Unexport combinations from Oscar.LieAlgebras

oscar-system · Aug 21, 2024 · d27e6c1 · d27e6c1
1 parent e7b8ce9
commit d27e6c1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/experimental/FTheoryTools/src/FamilyOfSpaces/attributes.jl b/experimental/FTheoryTools/src/FamilyOfSpaces/attributes.jl
@@ -126,7 +126,7 @@ Ideal generated by
   ring = coordinate_ring(f)
   variables = gens(ring)
   all_indices = collect(1:length(variables))
-  combis = Oscar.combinations(length(variables), dim(f))
+  combis = AbstractAlgebra.combinations(length(variables), dim(f))
   combis = [setdiff(all_indices, c) for c in combis]
   ideal_generators = [prod([variables[i] for i in c]) for c in combis]
   return ideal(ideal_generators)

diff --git a/experimental/LieAlgebras/src/Combinatorics.jl b/experimental/LieAlgebras/src/Combinatorics.jl
@@ -3,7 +3,7 @@
 # more efficient implementation.
 
 function combinations(n::Integer, k::Integer)
-  return sort(subsets(n, k))
+  return sort(AbstractAlgebra.combinations(n, k))
 end
 
 @doc raw"""

diff --git a/experimental/LieAlgebras/src/LieAlgebras.jl b/experimental/LieAlgebras/src/LieAlgebras.jl
@@ -121,7 +121,6 @@ export cartan_type_with_ordering
 export chevalley_basis
 export coefficient_vector
 export coerce_to_lie_algebra_elem
-export combinations
 export conjugate_dominant_weight
 export conjugate_dominant_weight_with_elem
 export coroot