-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add regular_character
#3393
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This would resolve #3390 assuming we export |
Exporting |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3393 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 557 557
Lines 73971 73975 +4
=======================================
+ Hits 60734 60738 +4
Misses 13237 13237
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually regular_character
can assume that the class of the identity element is the first one, thus the function need not do computations with the group.
(I should state this fact in the docstring for conjugacy_classes
for character tables.)
What about providing regular_character(tbl::GAPGroupCharacterTable)
,
and defining regular_character(G::GAPGroup) = regular_character(character_table(G))
?
I think what @ThomasBreuer suggests would be the way to go. Of course we can also do that later if you need this in immediately. |
Adjusted following your comments. Please have a look again @ThomasBreuer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. Just one minor comment on a docstring.
CC: @joschmitt