Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to flint 3 #3689

Merged
merged 1 commit into from
May 6, 2024
Merged

Update to flint 3 #3689

merged 1 commit into from
May 6, 2024

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented May 4, 2024

We are slowly converging to a point, where we could/should update to flint 3. We already have PRs adjusting Nemo and Hecke. They just need to be merged:

@thofma thofma marked this pull request as ready for review May 5, 2024 19:49
@thofma thofma closed this May 5, 2024
@thofma thofma reopened this May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (c6300cf) to head (6571f18).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3689      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.01%     
==========================================
  Files         577      577              
  Lines       78306    78311       +5     
==========================================
  Hits        65090    65090              
- Misses      13216    13221       +5     
Files Coverage Δ
src/Serialization/Fields.jl 94.71% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works

@thofma thofma merged commit c8e18de into master May 6, 2024
32 of 57 checks passed
@thofma thofma deleted the th/flint3 branch May 6, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants