Fix some combinatorics #3860
Merged
Fix some combinatorics #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
+ Coverage 81.84% 81.86% +0.01%
==========================================
Files 580 581 +1
Lines 79900 80012 +112
==========================================
+ Hits 65398 65502 +104
- Misses 14502 14510 +8
|
|
@joschmitt in file |
JohnAAbbott
approved these changes
Jun 17, 2024
Yes, I should also put it there. Thank you! |
|
@benlorenz It would be good to have this in 1.1. It contains some bugfixes and might be nice to have for the Begehung. |
benlorenz
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Make sure the combinatorics functions work for every integer type * Fix `is_standard` for negative values * Fix documentation of Schur polynomials * Fix `schur_polynomial` * Change one-line/terse printing of tableaux (cherry picked from commit 265e89c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the issues mentioned in #3850.