Add proper OSCAR type for tropical polyhedra #4001
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymake has support for tropical polyhedra, but what is there does not interface so nicely with OSCAR.
This PR serves to add a proper Julia type
TropicalPolyhedron
and provide basic functionality, to fix some design decisions about the data type.This might also be useful in light of #3989 (review).
EDIT: I discussed this PR with @micjoswig and we came up with the following outline.
In terms of data types: try a map which send a set (describing the stratum) to a polyhedral complex. Beware that polyhedral complexes require the vertices to be numbered consecutively. Because each stratum only sees a subset of the given points, we need an array and a map for translating indices back and forth.