-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GSets better inferreable #4052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Just for curiosity: If we introduce a type parameter that describes the elements of the G-set then wouldn't it be more logical to take the element type itself and not the type of the seeds?
That is indeed a good question. I'll play around with it tomorrow to see if I can get it working like that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4052 +/- ##
==========================================
+ Coverage 84.62% 84.63% +0.01%
==========================================
Files 600 600
Lines 82590 82610 +20
==========================================
+ Hits 69894 69921 +27
+ Misses 12696 12689 -7
|
By adding a type parameter which represents the element type of the G-set (derived from the eltype of the seed iterator).
This then allows to concretize the return types of
orbits
andelements
to something concretely that is statically known, i.e. in these two functions there is no dynamic dispatch happening, and they infer their concrete return type.I noticed this issue while profiling some new functionality in #4053, since half of the flame graph was filled with dynamic dispatch stuff.