Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GSets better inferreable #4052

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Aug 28, 2024

By adding a type parameter which represents the element type of the G-set (derived from the eltype of the seed iterator).
This then allows to concretize the return types of orbits and elements to something concretely that is statically known, i.e. in these two functions there is no dynamic dispatch happening, and they infer their concrete return type.

I noticed this issue while profiling some new functionality in #4053, since half of the flame graph was filled with dynamic dispatch stuff.

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Just for curiosity: If we introduce a type parameter that describes the elements of the G-set then wouldn't it be more logical to take the element type itself and not the type of the seeds?

@lgoettgens
Copy link
Member Author

Thanks. Just for curiosity: If we introduce a type parameter that describes the elements of the G-set then wouldn't it be more logical to take the element type itself and not the type of the seeds?

That is indeed a good question. I'll play around with it tomorrow to see if I can get it working like that

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (5edd2b0) to head (c675cd4).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4052      +/-   ##
==========================================
+ Coverage   84.62%   84.63%   +0.01%     
==========================================
  Files         600      600              
  Lines       82590    82610      +20     
==========================================
+ Hits        69894    69921      +27     
+ Misses      12696    12689       -7     
Files with missing lines Coverage Δ
src/Groups/group_characters.jl 95.65% <100.00%> (+0.01%) ⬆️
src/Groups/gsets.jl 91.35% <100.00%> (-0.04%) ⬇️

... and 6 files with indirect coverage changes

@lgoettgens lgoettgens merged commit 66928b8 into oscar-system:master Aug 29, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/gset branch August 29, 2024 12:55
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Aug 29, 2024
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Aug 29, 2024
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Aug 30, 2024
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Aug 30, 2024
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Sep 5, 2024
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Sep 10, 2024
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants