[FTheoryTools] Better type inference #4073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at
get_attribute
uses all over Oscar, I found a lot of places in the FTheoryTools that could easily get enhanced by explicit type annotations.Futhermore, I found some things around
journal_name
missing, which are added here. And I also included the change ofeuler_characteristic
from QQFieldElem to Int from #4044 in here, as this might produce ugly conflicts otherwise.