Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Better type inference #4073

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

lgoettgens
Copy link
Member

While looking at get_attribute uses all over Oscar, I found a lot of places in the FTheoryTools that could easily get enhanced by explicit type annotations.

Futhermore, I found some things around journal_name missing, which are added here. And I also included the change of euler_characteristic from QQFieldElem to Int from #4044 in here, as this might produce ugly conflicts otherwise.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (629c37e) to head (17bf2a6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4073      +/-   ##
==========================================
+ Coverage   84.17%   84.63%   +0.46%     
==========================================
  Files         600      600              
  Lines       82568    82622      +54     
==========================================
+ Hits        69503    69931     +428     
+ Misses      13065    12691     -374     
Files with missing lines Coverage Δ
...heoryTools/src/AbstractFTheoryModels/attributes.jl 99.59% <100.00%> (+1.60%) ⬆️
...heoryTools/src/AbstractFTheoryModels/properties.jl 100.00% <100.00%> (+1.66%) ⬆️
.../FTheoryTools/src/HypersurfaceModels/attributes.jl 93.10% <100.00%> (ø)
...mental/FTheoryTools/src/TateModels/constructors.jl 97.46% <100.00%> (ø)
...FTheoryTools/src/WeierstrassModels/constructors.jl 95.65% <100.00%> (ø)

... and 40 files with indirect coverage changes

Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @lgoettgens for catching and fixing all of this. Truly appreciated! Great!

@HereAround HereAround merged commit a854435 into oscar-system:master Sep 4, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/ftheory-attributes branch September 5, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants