Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lie algebras: Add root system detection #4084

Merged

Update experimental/LieAlgebras/src/LieAlgebra.jl

5c289ad
Select commit
Loading
Failed to load commit list.
Merged

Lie algebras: Add root system detection #4084

Update experimental/LieAlgebras/src/LieAlgebra.jl
5c289ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 18, 2024 in 0s

84.67% (-0.02%) compared to 0b52e65

View this Pull Request on Codecov

84.67% (-0.02%) compared to 0b52e65

Details

Codecov Report

Attention: Patch coverage is 84.48276% with 45 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (0b52e65) to head (5c289ad).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/LieAlgebraIdeal.jl 10.52% 17 Missing ⚠️
experimental/LieAlgebras/src/LieAlgebra.jl 94.02% 11 Missing ⚠️
...xperimental/LieAlgebras/src/DirectSumLieAlgebra.jl 10.00% 9 Missing ⚠️
experimental/LieAlgebras/src/LieSubalgebra.jl 65.21% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
- Coverage   84.69%   84.67%   -0.02%     
==========================================
  Files         614      626      +12     
  Lines       83568    84208     +640     
==========================================
+ Hits        70780    71307     +527     
- Misses      12788    12901     +113     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/AbstractLieAlgebra.jl 98.91% <100.00%> (+7.71%) ⬆️
experimental/LieAlgebras/src/LieAlgebraModule.jl 90.67% <100.00%> (-0.40%) ⬇️
experimental/LieAlgebras/src/LinearLieAlgebra.jl 95.85% <100.00%> (+0.26%) ⬆️
experimental/LieAlgebras/src/Types.jl 97.04% <ø> (+0.59%) ⬆️
experimental/LieAlgebras/src/serialization.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/test/LieAlgebra-test.jl 100.00% <ø> (ø)
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 100.00% <ø> (ø)
experimental/LieAlgebras/test/setup_tests.jl 95.31% <100.00%> (+0.23%) ⬆️
experimental/LieAlgebras/src/LieSubalgebra.jl 58.71% <65.21%> (+1.24%) ⬆️
...xperimental/LieAlgebras/src/DirectSumLieAlgebra.jl 77.63% <10.00%> (-10.25%) ⬇️
... and 2 more

... and 56 files with indirect coverage changes