Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds free resolutions over quotient rings by using Singular.sres #4134

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
+76 −29
Open

Adds free resolutions over quotient rings by using Singular.sres #4134

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6b9dcc6
adapt module gens to quotient rings
Jun 6, 2024
f8a555b
adjusts signatures of `prune_with_map` and `_presentation_minimal`
Jun 18, 2024
3d35d0a
Merge branch 'master' into rm/fres-quotient-ring
Sep 23, 2024
6925b56
compute free resolutions over quotients with sres
Sep 23, 2024
f47f456
updates docu
Sep 23, 2024
14c7ab3
adds test
Sep 23, 2024
452dd02
fix tests
Sep 24, 2024
8588359
fix another test
Sep 24, 2024
71cbe8c
Add dispatch for singular-to-oscar conversion [no ci].
HechtiDerLachs Sep 24, 2024
5c2a895
Enable length shortcut.
HechtiDerLachs Sep 25, 2024
bb81af4
Update src/Modules/UngradedModules/ModuleGens.jl
HechtiDerLachs Sep 25, 2024
16985d5
Fix tests.
HechtiDerLachs Sep 25, 2024
846a464
fix test
Sep 25, 2024
11bf9f4
fix test
RafaelDavidMohr Sep 26, 2024
de3ec65
fix test
RafaelDavidMohr Sep 26, 2024
3db4e44
Bump Singular compat
lgoettgens Sep 27, 2024
64f6b44
Update src/Modules/UngradedModules/ModuleGens.jl
lgoettgens Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/Modules/UngradedModules/ModuleGens.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,11 @@ function (F::FreeMod{<:MPolyRingElem})(s::Singular.svector)
ctx = MPolyBuildCtx(Rx)

# shortcut in order not to allocate the dictionary
# if isone(length(s)) # TODO: length doesn't work!
# (i, e, c) = first(s)
# push_term!(ctx, R(c), e)
# return FreeModElem(sparse_row(Qx, [(i, finish(ctx))]))
# end
if isone(length(s))
(i, e, c) = first(s)
push_term!(ctx, R(c), e)
return FreeModElem(sparse_row(Qx, [(i, finish(ctx))]))
HechtiDerLachs marked this conversation as resolved.
Show resolved Hide resolved
end

cache = IdDict{Int, typeof(ctx)}()
for (i, e, c) in s
Expand All @@ -283,18 +283,21 @@ function (F::FreeMod{<:MPolyRingElem})(s::Singular.svector)
return FreeModElem(sparse_row(Rx, [(i, finish(ctx)) for (i, ctx) in cache]), F)
end

# TODO: move this eventually
length(s::Singular.svector) = Int(Singular.libSingular.pLength(s.ptr))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to Singular.jl before merging this PR. Sorting this out afterwards is more of a hassle than doing it right the first time


function (F::FreeMod{<:MPolyQuoRingElem})(s::Singular.svector)
Qx = base_ring(F)::MPolyQuoRing
Rx = base_ring(Qx)::MPolyRing
R = coefficient_ring(Rx)
ctx = MPolyBuildCtx(Rx)

# shortcut in order not to allocate the dictionary
# if isone(length(s)) # TODO: length doesn't work!
# (i, e, c) = first(s)
# push_term!(ctx, R(c), e)
# return FreeModElem(sparse_row(Qx, [(i, Qx(finish(ctx)))]))
# end
if isone(length(s))
(i, e, c) = first(s)
push_term!(ctx, R(c), e)
return FreeModElem(sparse_row(Qx, [(i, Qx(finish(ctx)))]))
end

cache = IdDict{Int, typeof(ctx)}()
for (i, e, c) in s
Expand Down
Loading