Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more fixes #4142

Merged
merged 58 commits into from
Oct 2, 2024
Merged

Some more fixes #4142

merged 58 commits into from
Oct 2, 2024

Commits on Sep 24, 2024

  1. Speed up simplification of complexes.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    accc8e1 View commit details
    Browse the repository at this point in the history

  2. Make radical computation actually work over extensions of QQ.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    93c4575 View commit details
    Browse the repository at this point in the history

  3. Set the default hash to zero for ideals.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    981ed63 View commit details
    Browse the repository at this point in the history

  4. Update src/Rings/mpoly-ideals.jl

    @HechtiDerLachs
    HechtiDerLachs authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b07ff91 View commit details
    Browse the repository at this point in the history

  5. Revert "Set the default hash to zero for ideals." 

    This reverts commit 981ed63.
    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4a085a1 View commit details
    Browse the repository at this point in the history

  6. Revert the use of unique./start-tor-browser.desktop

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    843a1dc View commit details
    Browse the repository at this point in the history

  7. Fix internals of radical.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    34ac7ef View commit details
    Browse the repository at this point in the history

  8. Add is_known_to_be_radical.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    223c836 View commit details
    Browse the repository at this point in the history

  9. Roll back to the convention that radical returns few generators.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1c19d7f View commit details
    Browse the repository at this point in the history

  10. Fix up hashing.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6082101 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Some improvements on elliptic surfaces.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    320002a View commit details
    Browse the repository at this point in the history

  2. Fix.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    783684d View commit details
    Browse the repository at this point in the history

  3. Fix up assertions.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2e9b228 View commit details
    Browse the repository at this point in the history

  4. Put the gens in the correct position.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c02dca0 View commit details
    Browse the repository at this point in the history

  5. Implement base change for divisors.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    211dc5c View commit details
    Browse the repository at this point in the history

  6. Some fixes and assertions about base changes.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2c94fb8 View commit details
    Browse the repository at this point in the history

  7. Avoid factorization where it is apparently expensive.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7d2622f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Extract types for resolutions of singularities to its own file. 

    Co-authored by afkafkafk13
    @HechtiDerLachs
    HechtiDerLachs committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8866d53 View commit details
    Browse the repository at this point in the history

  2. Attempt to re-enable simultaneous blowup.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    59e12e1 View commit details
    Browse the repository at this point in the history

  3. Fix up performance for simultaneous blowup.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e37061c View commit details
    Browse the repository at this point in the history

  4. Fix up restrition to closed embeddings.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b69ce30 View commit details
    Browse the repository at this point in the history

  5. Make elimination an option in radical computation and update docstring.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f8645db View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Speed up arithmetic in localized rings.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cfd8e63 View commit details
    Browse the repository at this point in the history

  2. Speed up restriction of maps by introducing _images_of_generators.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c2bea04 View commit details
    Browse the repository at this point in the history

  3. Make radical accept keyword arguments for quotient rings.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6545b39 View commit details
    Browse the repository at this point in the history

  4. Disable internal checks.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c7f921c View commit details
    Browse the repository at this point in the history

  5. Polish method for simultaneous blowups.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e8cf31d View commit details
    Browse the repository at this point in the history

  6. Avoid hashing of types for ideals.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5052fa1 View commit details
    Browse the repository at this point in the history

  7. Adapt to the blowdown->blowup story.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a467cd6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into some_more_fixes

    @HechtiDerLachs
    HechtiDerLachs authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7c5e63b View commit details
    Browse the repository at this point in the history

  9. Remove duplicate type declarations.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7807c56 View commit details
    Browse the repository at this point in the history

  10. Move the other type as well.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4173626 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Re-establish some compositions.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1a5e0e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into some_more_fixes

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    06ad700 View commit details
    Browse the repository at this point in the history

  3. Fix up compositions.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6a10434 View commit details
    Browse the repository at this point in the history

  4. Take out inferred from the tests where we can't guarantee for anythin… 

    …g anymore.
    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    32b5883 View commit details
    Browse the repository at this point in the history

  5. Fix tests.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fff3d65 View commit details
    Browse the repository at this point in the history

  6. Fix up mapping.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    afd68e1 View commit details
    Browse the repository at this point in the history

  7. Fix up some more composition.

    @HechtiDerLachs
    HechtiDerLachs committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    67c4d72 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Overhaul composition once again.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fac1013 View commit details
    Browse the repository at this point in the history

  2. Put type declarations outside and extend composition methods slightly.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    37bd37a View commit details
    Browse the repository at this point in the history

  3. Disable new methods for the moment.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    71503c8 View commit details
    Browse the repository at this point in the history

  4. Pass on the check flag in some more cases.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    67265a0 View commit details
    Browse the repository at this point in the history

  5. Hopefully fix up tests.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    05e5518 View commit details
    Browse the repository at this point in the history

  6. Fix up composition.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1e4fb10 View commit details
    Browse the repository at this point in the history

  7. Fix up tests.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ca8ea64 View commit details
    Browse the repository at this point in the history

  8. Fix doctests in AG.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6429108 View commit details
    Browse the repository at this point in the history

  9. Allow slightly more flexibility in the strict transform of closed emb… 

    …eddings.
    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dd08681 View commit details
    Browse the repository at this point in the history

  10. Catch an important special case in is_refinement.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ebacd2e View commit details
    Browse the repository at this point in the history

  11. Fix doctests in mpoly-ideals.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8fe421c View commit details
    Browse the repository at this point in the history

  12. Fix doctests in FTheoryTools.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    183ecf4 View commit details
    Browse the repository at this point in the history

  13. Fix doctests in AlgebraicStatistics.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4d7f64e View commit details
    Browse the repository at this point in the history

  14. Disable isomorphism_on_open_subset.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d93df25 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into some_more_fixes

    @HechtiDerLachs
    HechtiDerLachs committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    cace0ba View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Revert "Fix doctests in AlgebraicStatistics." 

    This reverts commit 4d7f64e.
    @HechtiDerLachs
    HechtiDerLachs committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    63c1e3f View commit details
    Browse the repository at this point in the history

  2. Revert "Fix doctests in FTheoryTools." 

    This reverts commit 183ecf4.
    @HechtiDerLachs
    HechtiDerLachs committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8ec2a8d View commit details
    Browse the repository at this point in the history

  3. Actually remove isomorphism_on_open_subset.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    cc4a956 View commit details
    Browse the repository at this point in the history

  4. Remove duplicated code for compositions.

    @HechtiDerLachs
    HechtiDerLachs committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a03191c View commit details
    Browse the repository at this point in the history