more functionality for collector objects #4157
Draft
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create an Oscar collector from a GAP collector
ThomasBreuer
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4157 +/- ##
=======================================
Coverage 84.69% 84.70%
=======================================
Files 627 627
Lines 84300 84327 +27
=======================================
+ Hits 71399 71430 +31
+ Misses 12901 12897 -4
|
lgoettgens
reviewed
Sep 27, 2024
| @@ -82,3 +82,13 @@ end | |||
| @test GAP.Globals.IsMutable(cgg) | |||
| @test cgg !== c.X | |||
| end | |||
|
|
|||
| @testset "create collectors from polycyclic groups" begin | |||
| for i in rand(1:number_small_groups(96), 10) | |||
There was a problem hiding this comment.
Suggested change
| for i in rand(1:number_small_groups(96), 10) | |
| for i in rand(1:number_of_small_groups(96), 10) |
the old version is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create an Oscar collector from a GAP collector
(suggested by @fieker)