Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer symbols over strings as indeterminants #4158

Merged
merged 12 commits into from
Oct 7, 2024

fixes

f3d075e
Select commit
Loading
Failed to load commit list.
Refresh
Merged

Prefer symbols over strings as indeterminants #4158

fixes
f3d075e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 0s

84.70% (-0.01%) compared to 32a38b3, passed because coverage increased by 0% when compared to adjusted base (84.69%)

View this Pull Request on Codecov

84.70% (-0.01%) compared to 32a38b3, passed because coverage increased by 0% when compared to adjusted base (84.69%)

Details

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (32a38b3) to head (f3d075e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
experimental/FTheoryTools/src/auxiliary.jl 81.81% 2 Missing ⚠️
experimental/IntersectionTheory/src/Bott.jl 50.00% 1 Missing ⚠️
...metricIntersections/src/symmetric_grassmannians.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4158      +/-   ##
==========================================
- Coverage   84.70%   84.70%   -0.01%     
==========================================
  Files         628      628              
  Lines       84449    84447       -2     
==========================================
- Hits        71529    71527       -2     
  Misses      12920    12920
Files with missing lines Coverage Δ
...rimental/BasisLieHighestWeight/src/WeylPolytope.jl 100.00% <100.00%> (ø)
.../FTheoryTools/src/AbstractFTheoryModels/methods.jl 78.27% <100.00%> (ø)
...TheoryTools/src/HypersurfaceModels/constructors.jl 96.72% <100.00%> (ø)
...tal/FTheoryTools/src/HypersurfaceModels/methods.jl 100.00% <100.00%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 93.81% <100.00%> (ø)
...mental/FTheoryTools/src/TateModels/constructors.jl 97.46% <100.00%> (ø)
...xperimental/FTheoryTools/src/TateModels/methods.jl 66.29% <100.00%> (ø)
...FTheoryTools/src/WeierstrassModels/constructors.jl 95.65% <100.00%> (ø)
...ntal/FTheoryTools/src/WeierstrassModels/methods.jl 100.00% <100.00%> (ø)
...erimental/FTheoryTools/test/hypersurface_models.jl 100.00% <ø> (ø)
... and 29 more

... and 2 files with indirect coverage changes

View more details on Codecov