Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer symbols over strings as indeterminants #4158
base: master
Are you sure you want to change the base?
Prefer symbols over strings as indeterminants #4158
Changes from all commits
0c1b088
fdcf7ac
be442cb
e4df886
379f2df
bc56933
3fa4532
124b1b8
658e5ea
f3d075e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HereAround pinging you to make you aware that
symbols(::MPolyRing)
exists. In many of these cases you probably don't even need to convert to strings afterwards, but I kept it like this if I didn't see an obvious way to change the below codeCheck warning on line 318 in experimental/FTheoryTools/src/auxiliary.jl
Codecov / codecov/patch
experimental/FTheoryTools/src/auxiliary.jl#L318
Check warning on line 474 in experimental/FTheoryTools/src/auxiliary.jl
Codecov / codecov/patch
experimental/FTheoryTools/src/auxiliary.jl#L474
Check warning on line 171 in experimental/IntersectionTheory/src/Bott.jl
Codecov / codecov/patch
experimental/IntersectionTheory/src/Bott.jl#L171