-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hasse-Schmidt derivatives 2.0 #4272
Hasse-Schmidt derivatives 2.0 #4272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments about the bibliography. I am not familiar with the mathematics and will leave that for Anne to comment on.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4272 +/- ##
==========================================
+ Coverage 84.48% 84.52% +0.04%
==========================================
Files 641 646 +5
Lines 85427 85606 +179
==========================================
+ Hits 72170 72359 +189
+ Misses 13257 13247 -10
|
Algorithm and documentation look good now. |
@KilianBruns I don't understand, why is #3912 "abandoned", aren't you the author as well?? But if you really want a new branch and PR, please close the old one. |
@KilianBruns I just cleaned up the bibliography using |
94e868d
to
b9a03bd
Compare
b9a03bd
to
2a3de18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go, as soon as the two remaining points (deleting a reference and two lines) have been treated.
@KilianBruns Thank you for doing this PR
@joschmitt Thank you for cleaning up the bibliography
Thank you all for your help! |
This is a new version of the abbandoned pull request #3912
Most comments of the last pull request have been considered.
Added
(Implemented at the request of @afkafkafk13)
Closes #3912 .