Skip to content

Commit

Permalink
bump singular version (#380)
Browse files Browse the repository at this point in the history
  • Loading branch information
tthsqe12 committed Mar 6, 2021
1 parent 9cf18bd commit e53a905
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ AbstractAlgebra = "0.13"
CxxWrap = "0.11"
Nemo = "0.20"
RandomExtensions = "0.4.2"
Singular_jll = "~402.000.101"
Singular_jll = "~402.000.102"
julia = "1.3"
libsingular_julia_jll = "~0.8"
libsingular_julia_jll = "~0.9"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
2 changes: 1 addition & 1 deletion src/caller.jl
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function create_ring_from_singular_ring(r::libSingular.ring_ptr)
p = Int(libSingular.n_GetChar(c))
@assert libSingular.n_NumberOfParameters(c) == 1
S = [Symbol(libSingular.n_ParameterName(0, c))]
F = N_FField(iszero(p) ? QQ : N_ZpField(pf), S)
F = N_FField(iszero(p) ? QQ : N_ZpField(p), S)
# now create the extension
minpoly = F(libSingular.algExt_GetMinpoly(c, F.ptr))
K = N_AlgExtField(libSingular.nCopyCoeff(c), minpoly)
Expand Down
14 changes: 4 additions & 10 deletions test/caller-test.jl
Original file line number Diff line number Diff line change
Expand Up @@ -145,23 +145,17 @@ end
I = Ideal(R, a*z-x^4, z-y^6)
l = Singular.LibNormal.normal(I)
S = l[1][1][1]
# the correct tests for when the possible bug is fixed
#@test isa(S, Singular.PolyRing{n_algExt})
#@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*a) == K
@test isa(S, Singular.PolyRing{n_transExt})
@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*Fa) == F
@test isa(S, Singular.PolyRing{n_algExt})
@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*a) == K

F, (Fa,) = FunctionField(Fp(7), ["a"])
K, a = AlgebraicExtensionField(F, Fa^2 + 1)
R, (x, y, z) = PolynomialRing(K, ["x", "y", "z"])
I = Ideal(R, a*z-x^4, z-y^6)
l = Singular.LibNormal.normal(I)
S = l[1][1][1]
# the correct tests for when the possible bug is fixed
#@test isa(S, Singular.PolyRing{n_algExt})
#@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*a) == K
@test isa(S, Singular.PolyRing{n_transExt})
@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*Fa) == F
@test isa(S, Singular.PolyRing{n_algExt})
@test base_ring(gens(l[1][1][2][:norid])[1]*gens(S)[1]*a) == K
end

@testset "caller.lists" begin
Expand Down

0 comments on commit e53a905

Please sign in to comment.