Merge pull request #199 from raulepure/maximalindepset

Bug fix maximal_independent_set
oscar-system · Feb 27, 2020 · f2deec1 · f2deec1 · thofma · Mar 4, 2020
2 parents 6b5a006 + 361acb4
commit f2deec1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/ideal/ideal.jl b/src/ideal/ideal.jl
@@ -726,9 +726,10 @@ end
 function maximal_independent_set(I::sideal{S}; all::Bool = false) where S <: Union{spoly{T}, spoly{n_unknown{U}}} where {T <: Singular.FieldElem, U <: Nemo.FieldElem}
    I.isGB == false && error("I needs to be a Gröbner basis.")
    R = base_ring(I)
+   Q = base_ring(R)
    d = dimension(I)
    if all == true
-      P = Array{Array{spoly, 1}, 1}()
+      P = Array{Array{spoly{elem_type(Q)}, 1}, 1}()
       res = independent_sets(I)
       for i in 1:length(res)
          if length(res[i]) == d
@@ -739,7 +740,7 @@ function maximal_independent_set(I::sideal{S}; all::Bool = false) where S <: Uni
    else
       a = Array{Int32, 1}()
       libSingular.scIndIndset(I.ptr, R.ptr, a, all)
-      P = Array{spoly, 1}()
+      P = Array{spoly{elem_type(Q)}, 1}()
       for j in findall(x->x == 1, a)
          push!(P, gen(R, j))
       end

diff --git a/test/ideal/sideal-test.jl b/test/ideal/sideal-test.jl
@@ -333,5 +333,7 @@ end
    @test L1 == [x, y, u]
    @test L2 == [[x, y, u], [y, u, v], [x, u, w], [u, v, w]]
    @test L3 == [[x, y, u], [y, u, v], [x, u, w], [u, v, w], [y, w]]
+   @test typeof(L1) == Array{spoly{n_Q}, 1}
+   @test typeof(L2) == Array{Array{spoly{n_Q}, 1}, 1}
 end