Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete_reduction for reduce #682

Merged
merged 1 commit into from
Jul 25, 2023
Merged

complete_reduction for reduce #682

merged 1 commit into from
Jul 25, 2023

Conversation

hannes14
Copy link
Member

No description provided.

@ederc
Copy link
Member

ederc commented Jul 25, 2023

complete_reduction's default value for reduce is true whereas in #681 the default for divrem is false. Is this due to some specific reason? Otherwise I would propose to choose the same default setting for both functions.

@hannes14
Copy link
Member Author

to be consistent with previous version: reduce(A,B) is the same as reduce(A,B,complete_reduction=true)

@hannes14 hannes14 merged commit 9ec03a7 into oscar-system:master Jul 25, 2023
12 checks passed
@hannes14 hannes14 deleted the hs/reduce branch July 25, 2023 13:13
hannes14 added a commit that referenced this pull request Jul 28, 2023
* divrem with flag complete_reduction

* complete_reduction for reduce (#682)

* implementation via idLift and options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants