Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divrem with flag complete_reduction #681

Merged
merged 3 commits into from
Jul 28, 2023
Merged

divrem with flag complete_reduction #681

merged 3 commits into from
Jul 28, 2023

Conversation

hannes14
Copy link
Member

to use for reduce/redeuce_with_quotient/reduce_with_quotient_and_unit
@ederc,@wdecker

@hannes14 hannes14 requested a review from ederc July 24, 2023 13:42
@ederc
Copy link
Member

ederc commented Jul 25, 2023

There are two comments I want to make:

  1. I am not sure if divrem really is doing what we want. Looking at the following example I expect that the last two commands should return the same matrix:
julia> R, (x, y) = polynomial_ring(QQ, ["x", "y"])
(Singular Polynomial Ring (QQ),(x,y),(dp(2),C), spoly{n_Q}[x, y])

julia> a = Ideal(R,[x^2+x*y])
Singular ideal over Singular Polynomial Ring (QQ),(x,y),(dp(2),C) with generators (x^2 + x*y)

julia> b = Ideal(R,[x+y])
Singular ideal over Singular Polynomial Ring (QQ),(x,y),(dp(2),C) with generators (x + y)

julia> quo, rem, unit = divrem(a,b);

julia> Matrix(a)*Matrix(unit)
[x^2 + x*y]

julia> Matrix(b)*Matrix(quo)+Matrix(rem)
[x^2 + 2*x*y + y^2]

Or to be more explicit: I do not know where the +y is coming from looking at quo:

julia> Matrix(quo)
[x + y]
  1. Don't we need the complete_reduction flag also for reduce in order to be consistent?

@hannes14
Copy link
Member Author

reduce: see #682

@hannes14 hannes14 merged commit 9d08f66 into oscar-system:master Jul 28, 2023
11 of 13 checks passed
@hannes14 hannes14 deleted the hs/divrem branch July 28, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants