Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Singular methods with thread safety checks. #258

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rbehrends
Copy link
Contributor

These changes add a submodule Sync to Singular so that methods of the form Singular.f(...) can be called through Singular.Sync.f(...) in a thread-safe fashion.

@fieker
Copy link
Contributor

fieker commented Dec 4, 2020

what is the status here? Not complete? WIP? overlooked? Controversial? GoodToGo?
...
apart from the conflicts that is

@rbehrends
Copy link
Contributor Author

I haven't updated it in a while, I will probably be able to make it current on Monday.

It currently runs on an opt-in basis, as there is non-trivial overhead involved in calling Singular through the thread-safe API. It allows you to use a thread-safe API (with identical method signatures and behavior) if you're running multiple Julia threads that access the C/C++ functionality of Singular concurrently. In theory.

Thus, it should not get in the way of normal operations, once the conflicts have been cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants