adapt to array changes in julia nightly #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs JuliaInterop/libcxxwrap-julia#137 which is not released yet.Also requires some parts of JuliaLang/julia#52248 (depending on how this gets merged the
#if
can be removed again).I removed an unused Int32 case from
jl_array_to_intvec
, this is only used with an explicit Int64 vector anyway.Locally (on Linux) this works fine with julia 1.6.7, 1.9.4 and nightly with my julia PR and a custom libcxxwrap + cxxwrap.
Note that this branch was based on 0.19 instead of the latest master to allow testing with Oscar.rebased on master.