Extending GB for modules to non-commutative #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Sep 19, 2024
fingolfin
reviewed
Sep 19, 2024
fingolfin
reviewed
Sep 19, 2024
| """ | ||
| (R::PolyRing{T})(m::libSingular.poly,::Val{:vector}) where T | ||
|
|
There was a problem hiding this comment.
There really should be an empty line here.
fingolfin
reviewed
Sep 19, 2024
| @@ -38,7 +38,7 @@ function checkbounds(I::smodule, i::Int) | |||
| (i > ngens(I) || i < 1) && throw(BoundsError(I, i)) | |||
| end | |||
|
|
|||
| function getindex(I::smodule{T}, i::Int) where T <: AbstractAlgebra.RingElem | |||
| function getindex(I::smodule{T}, i::Int) where T | |||
There was a problem hiding this comment.
Maybe
Suggested change
| function getindex(I::smodule{T}, i::Int) where T | |
| function getindex(I::smodule{T}, i::Int) where T <: Nemo.NCRingElem |
fingolfin
reviewed
Sep 19, 2024
| function *(a::svector{Singular.spluralg{T}}, b::Singular.spluralg{T}) where T <: AbstractAlgebra.RingElem | ||
| base_ring(a) != parent(b) && error("Incompatible base rings") | ||
| R = base_ring(a) | ||
| s = GC.@preserve a b R libSingular.pp_Mult_qq(a.ptr, b.ptr, R.ptr) |
There was a problem hiding this comment.
Is libSingular.pp_Mult_qq the correct function to call here? Maybe @hannes14 can comment
fingolfin
reviewed
Sep 19, 2024
| function *(b::Singular.spluralg{T}, a::svector{Singular.spluralg{T}}) where T | ||
| base_ring(a) != parent(b) && error("Incompatible base rings") | ||
| R = base_ring(a) | ||
| s = GC.@preserve a b R libSingular.pp_Mult_qq(a.ptr, b.ptr, R.ptr) |
There was a problem hiding this comment.
Same question here: is this the right function to call here?
There was a problem hiding this comment.
Yes, pp_Mult_qq (and most other p_,pp_ routines) work for all types of Singular rings.
fingolfin
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for extending Groebner basis machinery for submodules to non-commutative rings. This is to support the pull request #3900 in Oscar.jl