Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Enforce -no-pie for compiling LTP tests on 18.04+ platforms #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chiache
Copy link
Member

@chiache chiache commented Jul 8, 2019

Some LTP tests (e.g., brk01) assumes the executables to be position-independent. As a result, these tests can fail on Ubuntu 18.04+ if -pie is adopted as the default for GCC 5+. To stablize these tests, we need to force -no-pie when compiling LTP binaries.


This change is Reviewable

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assumes the executables to be position-independent.

I think you meant position-dependent?

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @chiache)

a discussion (no related file):
Can we set -no-pie only to tests which really require it? I think having randomization enabled should allow us to detect more bugs (though this makes the tests less deterministic).


Copy link
Contributor

@yamahata yamahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chiache)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants