Refactor for Candidats Windows and more #1567
Merged
+554
−471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New BaseInputMessenger to hold the basic parts of input messages handling of input views - Remove ComposingPopupWindow and BaseMessageHandler
WhiredPlanck
force-pushed
the
refactor-20250122
branch
from
fa89e40 to
a8ada7f
Compare
…rectly The spans for spanned string can influence the line break strategy in TextView, therefore, CandidateItemSpan is implemented to replace the original CandidateSpan to fix the issue.
|
Another small bug fix. No any more commit for this PR now. |
|
Preview Screen_recording_20250126_215557_2.webm |
|
我的會覆蓋鍵盤，是因為方案設定的問題嗎？
|
目前窗口的定位还存在一些小问题，但我打算另开一个 PR 把其他相关的小修复给带上。这个 PR 的提交记录有点长了。 |
|
Bug: 候選視窗若曾使用「始終顯示」，那麼就算在選項中轉去「系統預設」或「停用」，候選視窗還是會繼續顯示。要強制停止 trime 才能回復。 |
这个对于其他设置来说也是如此，是一个普遍 bug。这时由于对设置项的变化监听做得不完整导致的，同样我将在最近几个 PR 内修复。 |
goofyz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
See the commit history for detail.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info