Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically resolve latest/current URLs for Debian/Ubuntu #647

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Automatically resolve latest/current URLs for Debian/Ubuntu #647

merged 10 commits into from
Sep 8, 2023

Conversation

mbuechse
Copy link
Contributor

@mbuechse mbuechse commented Sep 1, 2023

Resolves #639 and includes many minor improvements (including a somewhat alternative approach to #633).

@mbuechse
Use ruamel yaml consistently for roundtrip
aa52062 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Remove misleading assignment, for data is updated in place
cecb8c4 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Reverse checksum check in order to save indentation
b632587 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Avoid exception when simple test suffices
d54032a 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Extract distro-specific part into separate function
6945049 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Reverse logic in order to save indentation
42e7387 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Resolve Debian/Ubuntu latest/current to actual folder/file name
6567a22 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Only overwrite file on change; more comments
89200e3 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Minor simplifications around mirror_image
b9d07a4 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Minor simplifications around get_latest_default
4092359 
Signed-off-by: Matthias Büchse <[email protected]>
@berendt berendt added the SCS Sovereign Cloud Stack label Sep 6, 2023
@mbuechse
Copy link
Contributor Author

mbuechse commented Sep 6, 2023

To the reviewers: I tried to make small and self-contained commits. If the total change seems overwhelming, it could be worthwhile to look at each commit in isolation.

@gndrmnn
Copy link
Contributor

gndrmnn commented Sep 6, 2023

recheck

gndrmnn
gndrmnn approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@gndrmnn gndrmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
By the way, #627 will reduce the complexity even further as we pre-compute sha512 sums instead of relying on upstream hashes. (We will rebase this change into our branch soon)

lindenb1
lindenb1 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lindenb1 lindenb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mbuechse mbuechse mentioned this pull request Sep 7, 2023
Draft
2 tasks
@berendt berendt merged commit 49c7e12 into main Sep 8, 2023
4 checks passed
@berendt berendt deleted the issue/639 branch September 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindenb1 lindenb1 lindenb1 approved these changes

@gndrmnn gndrmnn gndrmnn approved these changes

@berendt berendt Awaiting requested review from berendt

Assignees
No one assigned
Labels
SCS Sovereign Cloud Stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve latest URL in update script
4 participants
@mbuechse @gndrmnn @lindenb1 @berendt