Fix save game #172
Merged
Fix save game #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
07c93d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1bb9642.slaytheweb.pages.dev |
| Branch Preview URL: | https://fix-savegame.slaytheweb.pages.dev |
|
OK seems to work now. The main issue was me not understanding javascript assign by value vs reference with objects. Previously upgraded cards would upgrade all instances instead of the specific one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in the
statethat we JSON serialize can't be parsed. Find what it is and learn how to make it serializable.The PR doesn't work yet.
Think one of the issues is that cards have an
upgrade()function which can't be stringified.Closes #171