feat: add support for jobs using cron #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
changed the title
xmnlab
reviewed
Jan 6, 2025
src/makim/scheduler.py
Outdated
|
|
||
| def _initialize_scheduler(self) -> None: | ||
| """Initialize the APScheduler with SQLite backend.""" | ||
| if Path(self.job_store_path).exists(): |
There was a problem hiding this comment.
I guess we cannot remove the file every initialization, otherwise we will lose history or links for tasks already running
abhijeetSaroha
force-pushed
the
corn-jobs
branch
2 times, most recently
from
385282e to
e88677c
Compare
abhijeetSaroha
force-pushed
the
corn-jobs
branch
from
e88677c to
2c0573c
Compare
xmnlab
reviewed
Jan 20, 2025
src/makim/scheduler.py
Outdated
| ) -> None: | ||
| """Execute a Makim task. | ||
|
|
||
| Args: |
xmnlab
reviewed
Jan 20, 2025
src/makim/cli/__init__.py
Outdated
| @@ -96,18 +99,233 @@ def _get_command_from_cli() -> str: | |||
| return command | |||
|
|
|||
|
|
|||
| def _create_cron_table() -> Table: | |||
There was a problem hiding this comment.
please move the scheduler code to its own module .. you can calle it as scheduler.py inside the cli folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #30