Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refactor): Change "service-groups" to "groups" #86

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

joel5vega
Copy link
Contributor

Pull Request description

Changed docref "service-groups" to "groups" to update documentation
Solving issue SPEC: Rename spec service-groups to groups #60
-->

How to test these changes

in linux run grep -iR "service-groups" and verify it doesn't return any value

  • ...

Pull Request checklists

This PR is a:

  • [x ] maintenance

About this PR:

  • pre-commit hooks were executed locally.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.

Additional information

Reviewer's checklist

image

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab xmnlab changed the title Changed docref "service-groups" to "groups" fix(refactor): Change "service-groups" to "groups" Nov 13, 2023
@xmnlab
Copy link
Member

xmnlab commented Nov 13, 2023

thanks for working on that @joel5vega ! appreciate that! LGTM (looks good to me)
the release workflow is not working, but it is not related to this PR
I am creating an issue for that.

@xmnlab xmnlab merged commit 98bd82c into osl-incubator:main Nov 13, 2023
4 of 5 checks passed
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants