Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change to dictionary format #97

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

joel5vega
Copy link
Contributor

changed from -name:name to name:

Pull Request description

Change to dictionary format

refactor: Issue #43

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

image
We may need to update sugar.py as well

image

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab
Copy link
Member

xmnlab commented Dec 11, 2023

please also update the documentation: https://github.com/osl-incubator/containers-sugar/blob/main/docs/index.md

@xmnlab
Copy link
Member

xmnlab commented Dec 11, 2023

osl-incubator/makim#28

PS: __main__.py would be the "same" as our cli.py

@joel5vega
Copy link
Contributor Author

osl-incubator/makim#28

PS: __main__.py would be the "same" as our cli.py
It seems that main_.py is now in makim.py and it can be compared with sugar.py
image

@joel5vega joel5vega reopened this Dec 18, 2023
@xmnlab
Copy link
Member

xmnlab commented Dec 20, 2023

@joel5vega thanks for working on that!

the linter is failing: https://github.com/osl-incubator/sugar/actions/runs/7268534099/job/19804578232?pr=97#step:5:17

in order to fix that, please run the following commands (within the sugar environment):

pre-commit install
pre-commit run --all-files
pre-commit run --all-files  # yes, run it twice to check if all the files were fixed.

because this issue was triggered by ruff-format, it will be fixed automatically ..
the other hooks when fail, need to be fixed manually.

ping if you have any question

@joel5vega
Copy link
Contributor Author

joel5vega commented Dec 20, 2023 via email

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @joel5vega

@xmnlab xmnlab merged commit 028096a into osl-incubator:main Dec 20, 2023
5 checks passed
Copy link

🎉 This PR is included in version 1.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants