-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change to dictionary format #97
Conversation
please also update the documentation: https://github.com/osl-incubator/containers-sugar/blob/main/docs/index.md |
PS: |
…ted documentation and test
@joel5vega thanks for working on that! the linter is failing: https://github.com/osl-incubator/sugar/actions/runs/7268534099/job/19804578232?pr=97#step:5:17 in order to fix that, please run the following commands (within the sugar environment): pre-commit install
pre-commit run --all-files
pre-commit run --all-files # yes, run it twice to check if all the files were fixed. because this issue was triggered by ruff-format, it will be fixed automatically .. ping if you have any question |
Great, it is updated
El mar, 19 dic 2023 a la(s) 9:58 p.m., Ivan Ogasawara (
***@***.***) escribió:
… @joel5vega <https://github.com/joel5vega> thanks for working on that!
the linter is failing:
https://github.com/osl-incubator/sugar/actions/runs/7268534099/job/19804578232?pr=97#step:5:17
in order to fix that, please run the following commands (within the sugar
environment):
pre-commit install
pre-commit run --all-files
pre-commit run --all-files # yes, run it twice to check if all the files were fixed.
because this issue was triggered by ruff-format, it will be fixed
automatically ..
the other hooks when fail, need to be fixed manually.
ping if you have any question
—
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTH6KAS7DTBKCQDYWKYVOTYKJA2TAVCNFSM6AAAAABAQPPZWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTG4ZTANJQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @joel5vega
🎉 This PR is included in version 1.9.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
changed from -name:name to name:
Pull Request description
Change to dictionary format
refactor: Issue #43
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Additional information
We may need to update sugar.py as well
Reviewer's checklist
Copy and paste this template for your review's note: