Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ID-porten clients #217

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add support for ID-porten clients #217

merged 3 commits into from
Mar 11, 2024

Conversation

simenheg
Copy link
Contributor

@simenheg simenheg commented Mar 8, 2024

Rename the okdata pubreg family of commands to okdata pubs (for "public services") to reflect that they now don't only handle Maskinporten clients, but also ID-porten clients.

@simenheg simenheg requested a review from a team March 8, 2024 12:35
@simenheg
Copy link
Contributor Author

simenheg commented Mar 8, 2024

Avhenger av oslokommune/okdata-maskinporten-api#168.

Rename the `okdata pubreg` family of commands to `okdata pubs` (for
"public services") to reflect that they now don't only handle
Maskinporten clients, but also ID-porten clients.
**required_style,
"type": "text",
"name": "client_uri",
"message": "Client URI/back URI",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir det lettere å lese om "back URI" står i parentes, slik at det ikke indikerer at det er et enten-eller-valg?

Copy link
Contributor

@petterhj petterhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTU 👍

@simenheg simenheg merged commit 558bd72 into main Mar 11, 2024
8 checks passed
@simenheg simenheg deleted the pubs branch March 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants