Suggestions #32
Open
Suggestions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krahulreddy
force-pushed
the
suggestions
branch
from
85a672c
to
4f5eb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code changes are made as part of GSoC 2020. This Pull Request contains changes made to Nominatim UI in order to provide suggestions to Nominatim DB.
The repository nominatim-indexing can be used to set up suggestions. This repository explains how to set up suggestions and how to use a hug API to create an endpoint to access these suggestions.
Once the elasticsearch indexing is complete, You can use the nominatim-ui to access these suggestions.
The following important things are to be set up in order for the suggestions to be accessible:
dist/config.js, Suggestions_Url needs to be updated with the url of your suggestions end point.dist/assets/js/suggest.js.The same changes mentioned here can be used to set up suggestions on any website. Few things like icon links need to be changed in
suggest.js.File changes description:
config.example.js: Added the suggestions endpoint as one of the parameters.search.html: search bar now uses suggest.js to provide suggestions.suggest.js: Makes the network calls on input and fetches the results. This script is responsible for providing suggestions.suggest.css: Few classes used to display the suggestions as an Unordered list with icons.