Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate_exported_and_imported_map_categories #4084

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nnngrach
Copy link
Contributor

@nnngrach nnngrach commented Nov 1, 2024

issue

video berfore

video.before.-Screen.Recording.2024-11-01.at.12.34.17.mov

video after

video.after.-.Screen.Recording.2024-11-01.at.12.39.43.mov

video android

android.-.Screen.Recording.2024-11-01.at.12.45.52.mov

@@ -510,6 +542,8 @@ - (void) exportSettings:(NSString *)fileDir fileName:(NSString *)fileName settin
myPlacesItems[type] = obj;
else if (type.isResourcesCategory)
resourcesItems[type] = obj;
else
BOOL stop = YES;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*stop = YES; ?

}
case EOASettingsItemFileSubtypeGpx:
{
if ([name hasSuffix:@".gpx"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to const

}
default: return NAN;
}
// BOOL hasAttributes = attributes != nil;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -206,6 +206,8 @@ + (void) increaseFreeMapsCount:(int)count

+ (BOOL) isPaidVersion
{
return YES;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

о_О

@@ -46,6 +46,8 @@ static NSString * const BINARY_SRTMF_MAP_INDEX_EXT_ZIP = @".srtmf.obf.zip";
static NSString * const BINARY_DEPTH_MAP_INDEX_EXT = @".depth.obf";
static NSString * const BINARY_DEPTH_MAP_INDEX_EXT_ZIP = @".depth.obf.zip";

static NSString * const TIF_EXT = @".depth.obf.zip";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -796,6 +831,15 @@ - (OAQuickActionsSettingsItem *)getBaseQuickActionsSettingsItem:(QuickActionButt
[routingFilesList addObject:fileItem.filePath];
else if (fileItem.subtype == EOASettingsItemFileSubtypeColorPalette)
[colorPaletteFilesList addObject:fileItem.filePath];

//TODO: why terrain without type?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -796,6 +831,15 @@ - (OAQuickActionsSettingsItem *)getBaseQuickActionsSettingsItem:(QuickActionButt
[routingFilesList addObject:fileItem.filePath];
else if (fileItem.subtype == EOASettingsItemFileSubtypeColorPalette)
[colorPaletteFilesList addObject:fileItem.filePath];

//TODO: why terrain without type?
else if (fileItem.subtype == EOASettingsItemFileSubtypeWikiMap || [[fileItem.filePath lowercaseString] hasSuffix:@"travel.obf"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "travel.obf" hardcoded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants