-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Famxplor web map #156
base: main
Are you sure you want to change the base?
Add Famxplor web map #156
Conversation
Looking at the map requires a "login or register with google" and later "Free to try during 30 days" |
Thanks for reviewing this PR @mtmail !
Yes. Creating an account is free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alt250,
thanks for your contribution, however I have to agree with @mtmail. Awesome-Lists are normally meant to showcase FOSS-projects, and whilst we do have a few non-open-source tools in our lists, all of them can be used for free.
I therefore see a problem with adding Famxplor to the main list. However we may still be able to work with this by adding a secondary list. Just as we have UNMAINTAINED.md
for unmaintained projects, we could have a NONFREE.md
.
My suggestion is for you to remove your change to the README.md
and create a NONFREE.md
with the following content instead:
# Non-Free Projects
The projects listed here are cool too, but can only be used against payment and don't publish their sources.
These commercial products are seperated from the main list to keep the main focus of the list on FOSS-projects.
## Contents
* [Maps](#maps)
* [Web Maps](#web-maps)
## Maps
### Web Maps
* [Famxplor](https://famxplor.com/) - World map featuring travel with kids blog posts. Find activities for your family vacations worldwide.
Let me know what you think!
Hey @Unkn0wnCat , I think that adding a It just happened that in the meantime, I decided to make Famxplor free! Famxplor is now free but still closed-source, so should I add it to |
As it is not FOSS, I think adding it to |
039f41f
to
aa18851
Compare
Hey @Unkn0wnCat, |
NONFREE.md
Outdated
The projects listed here are cool too, but they can only be used against payment or do not publish their sources. | ||
These commercial products are separated from the main list to keep the main focus on FOSS projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The projects listed here are cool too, but they can only be used against payment or do not publish their sources. | |
These commercial products are separated from the main list to keep the main focus on FOSS projects. | |
The projects listed here are cool too, but they require payment or do not publish their sources. | |
These products are separated from the main list to keep the main focus on FOSS projects. |
clarify payment, also commercial products can be free (as in freedom), and non-free (proprietary) produces can be gratis (and of course products can be neither or both), so try not to conflate them incorrectly
NONFREE.md
Outdated
|
||
### Web Maps | ||
|
||
* [Famxplor](https://famxplor.com/) - Explore a world map of travel blogs with child-tested activities and family vacation ideas from around the globe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps for each project, at the end add the short description in parenthesis why it is in this list e.g. (gratis but closed source)
or whatever happens to be the case
@mnalis Thanks for clarifying the text! |
I still think the website not OSM related enough and I don’t see it promoting OSM. Closed data is displayed on a base map behind a login, OSM attribution behind a tiny (i) on the bottom right of the map. 100.000s websites use a OSM basemap similarly. It’s one of five PRs to various awesome-* by the owner. |
@mtmail Thank you for the feedback! I appreciate your perspective on the OSM relevance. I'd like to clarify a few points:
While Famxplor does use OSM as its core mapping service, I understand the importance of making that more apparent. To address this, I've added a "Built with OpenStreetMap" link at the bottom of the map page. This is visible in the screenshot above. Regarding the multiple PRs to awesome-* projects, I submitted them in the hopes of contributing to lists where I thought the project might be relevant. However, I fully respect the maintainers' decision to include what they deem appropriate. Thank you for your understanding and encouragement! |
While I helped trying to format this PR to be more usable if it were to be accepted, I absolutely agree that the maintainer should make a decision about where they'd want to take this project (and document it). I.e., besides project having to be "awesome" (which is obviously highly subjective, and always subject to maintainer's final decision), should:
my personal preferences would be:
|
I fully understand that the submission of this project triggered these questions. |
Heyo everyone, sorry I've been a bit absent from this conversation. Thanks for all the input to this conversation from everyone! As mentioned by @alt250 we should move the discussion about adding non-free stuff to the Discussions tab. I've just created a topic there with my view of the problem: #158 Let's put this PR on ice for the length of the discussion. I encourage everyone who contibuted to this conversation to take part in the discussion: |
World map featuring family travel blog posts