Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add One-O-One stores #10394

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add One-O-One stores #10394

wants to merge 3 commits into from

Conversation

ClarSco
Copy link
Contributor

@ClarSco ClarSco commented Jan 24, 2025

One-O-One is a chain of convenience stores in Scotland.

According to its website (https://one-o-one.co.uk/) it has 45 branches across the country

One-O-One is a chain of convenience stores in Scotland. According to it's website (https://one-o-one.co.uk/) it has 45 branches across the country
@tommylung tommylung added the add brand Actionable - add a brand to the index label Jan 24, 2025
@UKChris-osm
Copy link
Collaborator

Thank you @ClarSco

Would "One O One" be more accurate?

I don't think they uses dashes in the name, just their web address?

Also, you can use gb-sct as the locationSet to target Scotland.

@ClarSco
Copy link
Contributor Author

ClarSco commented Jan 25, 2025

Both hyphenated and unhyphenated usage seems common across the relevant websites, though the hyphenated version appears more often in formal/legal contexts, which is why I defaulted to the hyphenated version. Here's a rough breakdown of their usages:

Places that use the hyphenated version

  • Companies House as "ONE-O-ONE CONVENIENCE STORES LIMITED"
  • all web addresses
  • the copyright line at the bottom of their website is styled as "ONE-O-ONE CONVENIENCE STORES LIMITED"
  • the parent company (Scotsman Group) list the shops under "ONE-O-ONE RETAIL" or "One-O-One Retail"on their website
  • Their "premium" stores appear to style the logo as "One · O · One Provisions Co." (using interpuncts rather than hyphens).

Places that use the unhyphenated version:

  • The address section on the main website
  • The body and "hamburger" menu text on the Scotsman group's website
  • The non-premium logo, used on most shop fronts/main website

Places that use both with similar frequency:

@ClarSco
Copy link
Contributor Author

ClarSco commented Jan 25, 2025

Also, you can use gb-sct as the locationSet to target Scotland.

Good point. Will change this as the Store Growth section of the website is explicit about them only looking expanding within Scotland.

@ClarSco ClarSco marked this pull request as draft January 25, 2025 17:03
One-O-One have no plans to expand outside Scotland, so limiting `locationSet` to `gb-sct` is appropriate
@ClarSco ClarSco marked this pull request as ready for review January 25, 2025 17:15
@ClarSco
Copy link
Contributor Author

ClarSco commented Jan 25, 2025

I should also add: in the FHRS database, many of these stores are listed under an older name of "G101", "G101 Off-sales", or similar. I doubt that many stores will have been tagged as such in the OSM, but if this is something that can be handled via the NSI, that would be great (though I don't know the appropriate schema).

@UKChris-osm
Copy link
Collaborator

UKChris-osm commented Jan 25, 2025

I thought I'd check overpass, and as it seems there are already a few entries within OSM that use the hyphen version, it makes sense to maintain that.

There is something we call matchNames that you can add to your entry, underneath locationSet, that you can add case-insensitive keywords that would match up, such as:

"matchNames": ["g101", "g101 off-sales"],

Add other names that appear in the FHRS database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants