begin with iavl v1.0.0 #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuvubk
reviewed
Nov 14, 2023
store/iavl/store.go
Outdated
| @@ -81,7 +81,7 @@ func LoadStoreWithInitialVersion(db dbm.DB, logger log.Logger, key types.StoreKe | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| istore.tree.(*immutableTree) | |||
There was a problem hiding this comment.
Is there any purpose? If not we should remove.
cc @faddat
* fix newMutableTree * replace log and dbm * migrate to cosmos ics23 * fix test * fix test * fix logger for test * fix conflict * fix test * fix unit test
|
IAVL v1 should be simpler to integrate in v0.47 btw: julienrbrt/cosmos-sdk-inj@f/v0.47.3-inj-1...ac1b893 |
|
@julienrbrt thanks very much for the helpful comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Eliminate or reduce daily epoch lag
Brief Changelog
Use iavl v1.0.0
Testing and Verifying
All unit tests should pass when running make test in the root of cosmos-sdk folder.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? not yet