Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using iavl v1.0.0 with cosmos sdk 0.47.5 #495

Closed
wants to merge 13 commits into from

Conversation

hieuvubk
Copy link

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high-level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Brief Changelog

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@faddat
Copy link
Member

faddat commented Nov 15, 2023

Fyi, on the PR I made, we got a super helpful comment from @julienbrt

julienrbrt/cosmos-sdk-inj@f/v0.47.3-inj-1...ac1b893

Copy link

github-actions bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 5, 2024
@czarcas7ic
Copy link
Member

Closing, since we currently are using a different branch for this

@czarcas7ic czarcas7ic closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants