Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing proto fields to gov v1 #497

Closed
wants to merge 1 commit into from
Closed

chore: add missing proto fields to gov v1 #497

wants to merge 1 commit into from

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Nov 23, 2023 •
edited
Loading

What is the purpose of the change

Adding missing proto fields to gov

Problem

When starting a node from scratch it fails, as we can't find the params below

panic: unknown field "min_expedited_deposit" in v1.DepositParams

goroutine 26 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustUnmarshalJSON(0x0?, {0xc001229400?, 0x0?, 0x0?}, {0x3b98020?, 0xc000ac6380?})
	github.com/cosmos/[email protected]/codec/proto_codec.go:187 +0x45

How to test

  • run a node on main in the osmosis repo
  • then checkout out this branch
  • run make proto-gen
  • link this branch to the osmosis node
  • run the node

@PaddyMc PaddyMc force-pushed the chore/add-gov-proto-missing-fields branch from 7384115 to 3bc80ed Compare November 23, 2023 21:56
@PaddyMc PaddyMc closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaddyMc