Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqsdomain package version #508

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix sqsdomain package version #508

merged 1 commit into from
Sep 10, 2024

Conversation

deividaspetraitis
Copy link
Collaborator

@deividaspetraitis deividaspetraitis commented Sep 10, 2024

Old version of v0.18.4-0.20240810225250-04d58c7c19a0 does not longer works and causes build errors, orginally noticed here. This PR fixes/bumps sqsdomain package version to fix an error.

#16 1.835 (22/22) Installing linux-headers (6.6-r0)
#16 1.953 Executing busybox-1.36.1-r29.trigger
#16 1.960 OK: 233 MiB in 37 packages
#16 2.025 + go mod download
#16 59.91 go: github.com/osmosis-labs/sqs/[email protected]: git init --bare in /go/pkg/mod/cache/vcs/9836731457b120de50ddba96f7ca828cbaa328ebb43584908b8a45a9a1a1a74e: exec: "git": executable file not found in $PATH
#16 ERROR: process "/bin/sh -c set -eux; apk add --no-cache ca-certificates build-base linux-headers &&     go mod download" did not complete successfully: exit code: 1
------
 > [builder 5/7] RUN set -eux; apk add --no-cache ca-certificates build-base linux-headers &&     go mod download:
1.590 (17/22) Installing g++ (13.2.1_git20240309-r0)
1.796 (18/22) Installing make (4.4.1-r2)
1.807 (19/22) Installing fortify-headers (1.1-r3)
1.817 (20/22) Installing patch (2.7.6-r10)
1.827 (21/22) Installing build-base (0.5-r3)
1.835 (22/22) Installing linux-headers (6.6-r0)
1.953 Executing busybox-1.36.1-r29.trigger
1.960 OK: 233 MiB in 37 packages
2.025 + go mod download
59.91 go: github.com/osmosis-labs/sqs/[email protected]: git init --bare in /go/pkg/mod/cache/vcs/9836731457b120de50ddba96f7ca828cbaa328ebb43584908b8a45a9a1a1a74e: exec: "git": executable file not found in $PATH
------

 2 warnings found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 42)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 10)
Dockerfile:20
--------------------
  19 |     
  20 | >>> RUN set -eux; apk add --no-cache ca-certificates build-base linux-headers && \
  21 | >>>     go mod download
  22 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c set -eux; apk add --no-cache ca-certificates build-base linux-headers &&     go mod download" did not complete successfully: exit code: 1
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c set -eux; apk add --no-cache ca-certificates build-base linux-headers &&     go mod download" did not complete successfully: exit code: 1`

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated dependencies to ensure compatibility and incorporate potential improvements and bug fixes.
    • Minor formatting adjustments made to the dependency declarations.

Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Walkthrough

The pull request involves updates to the go.mod file, focusing on the versioning of dependencies. The version of github.com/osmosis-labs/sqs/sqsdomain has been incremented from v0.18.4-0.20240810225250-04d58c7c19a0 to v0.18.4-0.20240823173943-3e62a5a6700c. Indirect dependencies cosmossdk.io/errors and github.com/cosmos/gogoproto have been maintained at version v1.0.1 and v1.4.11, respectively, with minor formatting adjustments made to comments in the file.

Changes

File Change Summary
go.mod Updated github.com/osmosis-labs/sqs/sqsdomain from v0.18.4-0... to v0.18.4-0.20240823173943-3e62a5a6700c; maintained versions for cosmossdk.io/errors and github.com/cosmos/gogoproto at v1.0.1 and v1.4.11; minor formatting adjustments.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GoModule
    participant Dependency

    Developer->>GoModule: Update dependencies
    GoModule->>Dependency: Fetch latest versions
    Dependency-->>GoModule: Return updated versions
    GoModule-->>Developer: Reflect changes in go.mod
Loading

Poem

🐇 In the meadow where code does play,
Dependencies hop, brightening the day.
A version up, a tidy line,
Bugs take flight, all feels fine!
With each small change, we leap and cheer,
For smoother paths, we hold so dear! 🌼

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3a7cda4 and bf2ef98.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (4 hunks)
Files skipped from review due to trivial changes (1)
  • go.mod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@deividaspetraitis deividaspetraitis self-assigned this Sep 10, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

@deividaspetraitis
Copy link
Collaborator Author

Note that we do not need backport here.

Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@p0mvn p0mvn merged commit 10b84b4 into v25.x Sep 10, 2024
9 of 10 checks passed
@p0mvn p0mvn deleted the sqsdomain-fix branch September 10, 2024 17:56
@coderabbitai coderabbitai bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants