Emit redacted errors #17
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -3,6 +3,7 @@ | |||
| import ( | |||
| "bytes" | |||
| "fmt" | |||
| "reflect" | |||
Check notice
Code scanning / CodeQL
Sensitive package import
| } | ||
|
|
||
| event := sdk.NewEvent(types.CustomContractEventPrefix+types.EventTypeRedactedError, attrs...) | ||
| ctx.EventManager().EmitEvent(event) |
There was a problem hiding this comment.
Please note that this is a cached context. In the SDK events are only emitted when the TX succeeds. There is no guarantee that this is the case.
The contract can decide to fail the TX on reply and rollback. When the contract handles the error reply, is there still value in the event?
There was a problem hiding this comment.
Ahh good catch! I'll make sure those events are copied to the parent when the context is discarded.
It's also a good question what we want to happen if the failed message is caught by the contract. I started writing this to be able to provide feedback when a transaction does ultimately fails, so I think it's ok for the events to be omitted if the contract catches the failure, as I assume that means the contract is properly handling the errors.
Do you think there is value in surfacing those errors anyway?
There was a problem hiding this comment.
ahh, this is annoying: this would have to be done in baseapp:runTx. Trying to figure out a good workaround
Initial implementation of CosmWasm#1122