Added Cmat in hydrodynamic forces equation #466
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acxz
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the hydrodynamic forces equation in
usv_gazebo_dynamics_plugin.ccto include the Coriolis centripetal matrix for added mass,Cmat.As mentioned in #441, the model used in the code does not match the Theory of operation (see eq. 1).
Note: There also seem to be differences in the terms present in
Cmatin Theory of operation, this paper and this definition. These differences have not been addressed in this PR.Need to verify if switching to this model is causing any unexpected behaviour in the USV. Do you remember if
Cmatwas purposely omitted, and if so, the reason for doing so?