remove addition of zero Z valued grid point #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X.Z() never gets populated with a nonzero value besides it's initial construction value of 0. Thus this addition is extraneous. With the removal of this addition, dz is the same as depth and the dz variable is also eliminated. An older comment is moved closer to where it should be based on the newer code code after the waveParams null check. Co-authored-by: Jonathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X.Z() never gets populated with a nonzero value besides it's initial construction value of 0. Thus this addition is extraneous.
Co-authored-by: Jonathan [email protected]