send-max: respect configuration

api/gobgp.proto

@@ -535,15 +535,16 @@ message Path {
   uint32 source_asn = 10;
   string source_id = 11;
   bool filtered = 12;
-  bool stale = 13;
-  bool is_from_external = 14;
-  string neighbor_ip = 15;
-  bytes uuid = 16; // only paths installed by AddPath API have this
-  bool is_nexthop_invalid = 17;
-  uint32 identifier = 18;
-  uint32 local_identifier = 19;
-  bytes nlri_binary = 20;
-  repeated bytes pattrs_binary = 21;
+  bool send_max_filtered = 13;
+  bool stale = 14;
+  bool is_from_external = 15;
+  string neighbor_ip = 16;
+  bytes uuid = 17; // only paths installed by AddPath API have this
+  bool is_nexthop_invalid = 18;
+  uint32 identifier = 19;
+  uint32 local_identifier = 20;
+  bytes nlri_binary = 21;
+  repeated bytes pattrs_binary = 22;
 }
 
 message Destination {

cmd/gobgp/neighbor.go

@@ -586,7 +586,7 @@ func getPathAttributeString(nlri bgp.AddrPrefixInterface, attrs []bgp.PathAttrib
 	return fmt.Sprint(s)
 }
 
-func makeShowRouteArgs(p *api.Path, idx int, now time.Time, showAge, showBest, showLabel, showMUP bool, showIdentifier bgp.BGPAddPathMode) []interface{} {
+func makeShowRouteArgs(p *api.Path, idx int, now time.Time, showAge, showBest, showLabel, showMUP, showSendMaxFiltered bool, showIdentifier bgp.BGPAddPathMode) []interface{} {
 	nlri, _ := apiutil.GetNativeNlri(p)
 
 	// Path Symbols (e.g. "*>")
@@ -650,17 +650,27 @@ func makeShowRouteArgs(p *api.Path, idx int, now time.Time, showAge, showBest, s
 	pattrstr := getPathAttributeString(nlri, attrs)
 	args = append(args, pattrstr)
 
+	if showSendMaxFiltered {
+		if p.SendMaxFiltered {
+			args = append(args, "send-max-filtered")
+		} else if p.Filtered {
+			args = append(args, "policy-filtered")
+		} else {
+			args = append(args, "not filtered")
+		}
+	}
+
 	updateColumnWidth(nlri.String(), nexthop, aspathstr, label, teid, qfi, endpoint)
 
 	return args
 }
 
-func showRoute(dsts []*api.Destination, showAge, showBest, showLabel, showMUP bool, showIdentifier bgp.BGPAddPathMode) {
+func showRoute(dsts []*api.Destination, showAge, showBest, showLabel, showMUP, showSendMaxFiltered bool, showIdentifier bgp.BGPAddPathMode) {
 	pathStrs := make([][]interface{}, 0, len(dsts))
 	now := time.Now()
 	for _, dst := range dsts {
 		for idx, p := range dst.Paths {
-			pathStrs = append(pathStrs, makeShowRouteArgs(p, idx, now, showAge, showBest, showLabel, showMUP, showIdentifier))
+			pathStrs = append(pathStrs, makeShowRouteArgs(p, idx, now, showAge, showBest, showLabel, showMUP, showSendMaxFiltered, showIdentifier))
 		}
 	}
 
@@ -691,6 +701,11 @@ func showRoute(dsts []*api.Destination, showAge, showBest, showLabel, showMUP bo
 	headers = append(headers, "Attrs")
 	format += "%-s\n"
 
+	if showSendMaxFiltered {
+		headers = append(headers, "Filtered")
+		format += "%-s\n"
+	}
+
 	fmt.Printf(format, headers...)
 	for _, pathStr := range pathStrs {
 		fmt.Printf(format, pathStr...)
@@ -839,6 +854,7 @@ func showNeighborRib(r string, name string, args []string) error {
 	showAge := true
 	showLabel := false
 	showMUP := false
+	showSendMaxFiltered := false
 	showIdentifier := bgp.BGP_ADD_PATH_NONE
 	validationTarget := ""
 	rd := ""
@@ -852,6 +868,7 @@ func showNeighborRib(r string, name string, args []string) error {
 		showBest = true
 	case cmdAdjOut:
 		showAge = false
+		showSendMaxFiltered = true
 	case cmdVRF:
 		def = ipv4UC
 		showBest = true
@@ -1058,7 +1075,7 @@ func showNeighborRib(r string, name string, args []string) error {
 			}
 		}
 		if len(dsts) > 0 {
-			showRoute(dsts, showAge, showBest, showLabel, showMUP, showIdentifier)
+			showRoute(dsts, showAge, showBest, showLabel, showMUP, showSendMaxFiltered, showIdentifier)
 		} else {
 			fmt.Println("Network not in table")
 		}

internal/pkg/table/destination.go

@@ -185,10 +185,7 @@ func rsFilter(id string, as uint32, path *Path) bool {
 		return false
 	}
 
-	if id != GLOBAL_RIB_NAME && (path.GetSource().Address.String() == id || isASLoop(as, path)) {
-		return true
-	}
-	return false
+	return id != GLOBAL_RIB_NAME && (path.GetSource().Address.String() == id || isASLoop(as, path))
 }
 
 func (dd *Destination) GetKnownPathList(id string, as uint32) []*Path {

internal/pkg/table/path.go

@@ -142,6 +142,15 @@ type Path struct {
 	IsNexthopInvalid bool
 	IsWithdraw       bool
 }
+type FilteredType uint8
+
+const (
+	NotFiltered FilteredType = 1 << iota
+	PolicyFiltered
+	SendMaxFiltered
+)
+
+type PathLocalKey string
 
 var localSource = &PeerInfo{}
 
@@ -566,7 +575,7 @@ func (path *Path) String() string {
 		s.WriteString(fmt.Sprintf("{ %s EOR | src: %s }", path.GetRouteFamily(), path.GetSource()))
 		return s.String()
 	}
-	s.WriteString(fmt.Sprintf("{ %s | ", path.getPrefix()))
+	s.WriteString(fmt.Sprintf("{ %s | ", path.GetPrefix()))
 	s.WriteString(fmt.Sprintf("src: %s", path.GetSource()))
 	s.WriteString(fmt.Sprintf(", nh: %s", path.GetNexthop()))
 	if path.IsNexthopInvalid {
@@ -579,7 +588,13 @@ func (path *Path) String() string {
 	return s.String()
 }
 
-func (path *Path) getPrefix() string {
+// GetLocalKey identifies the path in the local BGP server.
+func (path *Path) GetLocalKey() PathLocalKey {
+	// return PathLocalKey(path.GetPrefix())
+	return PathLocalKey(fmt.Sprintf("%s:%s:%d", path.GetRouteFamily(), path.GetNlri(), path.GetNlri().PathLocalIdentifier()))
+}
+
+func (path *Path) GetPrefix() string {
 	return path.GetNlri().String()
 }
 

internal/pkg/table/path_test.go

@@ -53,7 +53,7 @@ func TestPathGetPrefix(t *testing.T) {
 	peerP := PathCreatePeer()
 	pathP := PathCreatePath(peerP)
 	prefix := "10.10.10.0/24"
-	r_prefix := pathP[0].getPrefix()
+	r_prefix := pathP[0].GetPrefix()
 	assert.Equal(t, r_prefix, prefix)
 }
 

internal/pkg/table/table.go

@@ -171,7 +171,7 @@ func (t *Table) validatePath(path *Path) {
 			log.Fields{
 				"Topic":      "Table",
 				"Key":        t.routeFamily,
-				"Prefix":     path.GetNlri().String(),
+				"Prefix":     path.GetPrefix(),
 				"ReceivedRf": path.GetRouteFamily().String()})
 	}
 	if attr := path.getPathAttr(bgp.BGP_ATTR_TYPE_AS_PATH); attr != nil {