Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local CLUSTER_ID check in CLUSTER_LIST. #2237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kishiguro
Copy link
Contributor

local CLUSTER_ID check in CLUSTER_LIST should be performed to non route reflector client as well.
otherwise multi cluster configuration may have routing loop.

@kishiguro kishiguro changed the title local CLUSTER_ID check in CLUSTER_LIST check. local CLUSTER_ID check in CLUSTER_LIST. Feb 11, 2020
@fujita
Copy link
Member

fujita commented Feb 12, 2020

local CLUSTER_ID check in CLUSTER_LIST should be performed to non route reflector client as well.

Hmm, with the following description of rfc4456, I thought that only RR uses this attribute:

When an RR reflects a route, it MUST prepend the local CLUSTER_ID to
the CLUSTER_LIST. If the CLUSTER_LIST is empty, it MUST create a new
one. Using this attribute an RR can identify if the routing
information has looped back to the same cluster due to
misconfiguration.

Looks like that bird does the same:
https://github.com/CZ-NIC/bird/blob/master/proto/bgp/attrs.c#L1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants