Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to parse analysis complete notification JSON #629

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adaluong
Copy link
Member

This function makes it easier for downstream consumers (like package analysis) to parse the package analysis complete notification and identify the package being analysed.

Signed-off-by: Ada Luong [email protected]

@adaluong adaluong marked this pull request as draft February 10, 2023 02:40
@oliverchang
Copy link
Contributor

Is this still required?

@maxfisher-g
Copy link
Contributor

@calebbrown do we need this code?

@calebbrown
Copy link
Contributor

Long term - yes, I think this is the right place for this. Marshal/Unmarshal logic best exists next to the struct itself (e.g. url.Parse).

In this particularly case I am planning a small refactor in #651. So it's not critical to have this merged. Given the lack of unit tests we probably want to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants