disable strace debug logging in worker, add feature flag to enable separate logging in analysis image #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebbrown
requested changes
Oct 19, 2023
maxfisher-g
force-pushed
the
feature_disable_strace_debug_logging
branch
from
70e0d78 to
56e5a2f
Compare
Signed-off-by: Max Fisher <[email protected]>
Signed-off-by: Max Fisher <[email protected]>
maxfisher-g
force-pushed
the
feature_disable_strace_debug_logging
branch
from
56e5a2f to
d32e9fc
Compare
… if StraceDebugLogging feature is enabled Signed-off-by: Max Fisher <[email protected]>
maxfisher-g
changed the title
Signed-off-by: Max Fisher <[email protected]>
Signed-off-by: Max Fisher <[email protected]>
calebbrown
reviewed
Oct 23, 2023
Signed-off-by: Max Fisher <[email protected]>
calebbrown
approved these changes
Oct 23, 2023
Signed-off-by: Max Fisher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: reworked PR to disable strace debug logging by default, but add
StraceDebugLoggingfeature flag for the analysis image, which saves the debug logs to a separate file in the analysis container. This allows saving and inspecting specifically the strace parsing logs, which may be useful for strace development in the future.The logging calls with loglevel
Warn(reporting parsing errors) are now logged to the default logger, which means they are still available in the main logs as before, in both the worker and analysis images.Fixes #798.
Original: Fixes #798 via supressing debug output of strace logs rather than redirecting it, since there is currently no clear need to redirect.
If there is a need to save the debug output, we can open another issue.