Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dynamic analysis Load function #947

Merged
merged 1 commit into from
Nov 1, 2023
Merged

update dynamic analysis Load function #947

merged 1 commit into from
Nov 1, 2023

Conversation

maxfisher-g
Copy link
Contributor

Make the dynamic analysis Load function code consistent with the new LoadStaticAnalysis function

  • return errors instead of panicking
  • reuse job waiting logic from LoadStaticAnalysis()
  • add bigquery.Close() call

@maxfisher-g
dynamic analysis Load function: return errors instead of panicking, r…
31bc308 
…euse job waiting logic from LoadStaticAnalysis(), add bigquery.Close() call

Signed-off-by: Max Fisher <[email protected]>
@maxfisher-g maxfisher-g merged commit 3ad3fa9 into main Nov 1, 2023
8 checks passed
@maxfisher-g maxfisher-g deleted the loader_return_errors branch November 1, 2023 00:18
@maxfisher-g maxfisher-g mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebbrown calebbrown calebbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxfisher-g @calebbrown