-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable baits #948
Merged
maxfisher-g
merged 8 commits into
ossf:main
from
elainechien:add_environment_variable_baits
Nov 15, 2023
Merged
Add environment variable baits #948
maxfisher-g
merged 8 commits into
ossf:main
from
elainechien:add_environment_variable_baits
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elaine Chien <[email protected]>
Signed-off-by: Elaine Chien <[email protected]>
maxfisher-g
reviewed
Nov 7, 2023
maxfisher-g
reviewed
Nov 7, 2023
maxfisher-g
reviewed
Nov 7, 2023
maxfisher-g
requested changes
Nov 8, 2023
Signed-off-by: Elaine Chien <[email protected]>
maxfisher-g
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good!
Signed-off-by: Elaine Chien <[email protected]>
…lainechien/package-analysis into add_environment_variable_baits
maxfisher-g
approved these changes
Nov 15, 2023
calebbrown
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an AWS access key id and secret access key as environment variables. After analysis we can specifically search for whether these environment variable names are present in the output. This PR also modifies the sample python package to exfiltrate environment variables when sending an https post request.
#586, #1001