-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add token permissions to verify.yml workflow #1325
Conversation
@naveensrinivasan this PR seems ok to me because the action does not checkout the code or run it: it only looks at the PR description. Are we going to split this workflow using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Integration tests success for |
Integration tests success for |
Integration tests success for |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds minimum token permissions to the verify.yml workflow
What is the current behavior? (You can also link to an open issue here)
verify.yml workflow does not have token permissions set
What is the new behavior (if this is a feature change)?
verify.yml workflow has token permissions. Permissions were added automatically using https://app.stepsecurity.io/secureworkflow
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Step Security website now adds
permissions:read-all
at top level as discussed in Token-Permissions check clarification #1128. The automation adds a new line abovejobs:
. Let me know if there should be no new line or there should also be new line above thepermissions: read-all