✨ branch protection: requiring PRs gives partial credit #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoteles08
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
diogoteles08
had a problem deploying
to
gitlab
GitHub Actions
Failure
diogoteles08
had a problem deploying
to
integration-test
GitHub Actions
Failure
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
4b17d60
to
5f53749
Compare
diogoteles08
had a problem deploying
to
gitlab
GitHub Actions
Failure
diogoteles08
had a problem deploying
to
integration-test
GitHub Actions
Failure
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
5f53749
to
a7ca2b5
Compare
diogoteles08
had a problem deploying
to
gitlab
GitHub Actions
Failure
diogoteles08
had a problem deploying
to
integration-test
GitHub Actions
Failure
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
a7ca2b5
to
657fc4f
Compare
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3499 +/- ##
==========================================
- Coverage 76.24% 70.99% -5.26%
==========================================
Files 214 214
Lines 14625 14628 +3
==========================================
- Hits 11151 10385 -766
- Misses 2807 3623 +816
+ Partials 667 620 -47 |
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
657fc4f
to
b6778c2
Compare
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Can you rebase/merge in the changes from main before review? #3502 introduced some scoring changes, so you'll need to resolve the merge conflict. |
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
b6778c2
to
dae8813
Compare
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
diogoteles08
force-pushed
the
feat/branch-protection-recognize-rule-changes-only-through-pr
branch
from
dae8813
to
d170f83
Compare
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
pnacht
reviewed
Dec 7, 2023
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
…on when they dont contribute for clarification Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
…s-only-through-pr
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Dec 9, 2023
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
…th its purpose I also changed the test to not require PRs, as it's how it is when a new GitHub Branch Protection config is created. The changes on the loggings numbers are due to: 1. A warning for not having DismissStaleReviews became a debug 2. Removed the warning we had for not requiring CodeOwners 3. Have a new warning for not requiring PRe Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <[email protected]>
…s-only-through-pr Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
changed the title
2 tasks
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It's a feature, described on the corresponding issue
Which issue(s) this PR fixes
Fixes #2727
Notes for the reviewers
I tried to split the PR on independent commits, so it might be easier to review commit by commit.
The last commit were just refactors on the previously existent code of the file I worked on. Let me know if you prefer that I make the refactors as another PR.
Does this PR introduce a user-facing change?