Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SecureSoftwareGuidingPrinciples.md #266

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update SecureSoftwareGuidingPrinciples.md #266

merged 1 commit into from
Nov 2, 2023

Conversation

SecurityCRob
Copy link
Contributor

No description provided.

ware
ware approved these changes Oct 19, 2023
View reviewed changes
Copy link

@ware ware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lehors
Copy link
Contributor

lehors commented Oct 19, 2023

I think Signees is a better name for this than Signatures.

@lehors lehors mentioned this pull request Oct 19, 2023
Closed
@david-a-wheeler
Copy link
Contributor

+1

sevansdell
sevansdell reviewed Oct 19, 2023
View reviewed changes
Copy link

@sevansdell sevansdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of sight!

@sevansdell
Copy link

A couple comments from Jordan Harband in Slack... (not sure how to suggest edits other than this, so please provide on-the-job-training and I will apply these where needed):

  • s/open source software)/open source software.
  • principle 2: recommend "least privilege" link to https://csrc.nist.gov/glossary/term/least_privilege
  • Principle 3: "the most common kinds of vulnerabilities in our software's problem domain"
  • Principle 8: can you elaborate on "inclusive of upstream dependencies"? (open to team feedback here)

@SecurityCRob SecurityCRob merged commit c96e635 into main Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevansdell sevansdell sevansdell left review comments

@ware ware ware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SecurityCRob @lehors @david-a-wheeler @sevansdell @ware