Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure text remains visible during webfont load #22

Closed
alexdor opened this issue Sep 27, 2018 · 9 comments
Closed

Ensure text remains visible during webfont load #22

alexdor opened this issue Sep 27, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@alexdor
Copy link
Member

alexdor commented Sep 27, 2018

Leverage the font-display CSS feature to ensure text is user-visible while webfonts are loading. Learn more

@alexdor alexdor added the enhancement New feature or request label Sep 27, 2018
@himankpathak
Copy link
Contributor

Google fonts API does not support font-display property yet. Learn more
How should we go about resolving this issue? @alexdor

@alexdor
Copy link
Member Author

alexdor commented Oct 19, 2018

@himankpathak I think the best solution here is to download the fonts and include them in the project. That will allow us to use the font-display and it would load the fonts faster (because we use http2 so we will skip quite a few round trips). What do you think?

@himankpathak
Copy link
Contributor

@alexdor Yea, I was thinking the same to download and serve them through our project itself.
Also, there is no static directory so should I create a font directory in public or a static in src?

@alexdor
Copy link
Member Author

alexdor commented Oct 20, 2018

I would create a folder inside src/styles but you can create it where ever you want : ) It's better to do it inside the src/ folder in order to not skip webpack preparation of the assets.

Note: Don't forget to read this part https://github.com/ossn/fixme#adding-images-fonts-and-files in order to avoid common issues : )

@himankpathak
Copy link
Contributor

@alexdor created a PR! :)

@himankpathak
Copy link
Contributor

@alexdor Also I wanted to ask why do we use Raleway as the main font when numbers in Raleway font look up & down? Any specific reason for it?

@alexdor
Copy link
Member Author

alexdor commented Oct 20, 2018

@himankpathak The designers used it so we had to : )

@himankpathak
Copy link
Contributor

Okay @alexdor :P
I am really liking this project, great work done by you and @bacharakis.
Will love to help you out with other issue and features. 😄

@alexdor
Copy link
Member Author

alexdor commented Oct 20, 2018

Thanks @himankpathak : ) You could always try to tackle #15 or this comment #28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants