-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure text remains visible during webfont load #22
Comments
Google fonts API does not support font-display property yet. Learn more |
@himankpathak I think the best solution here is to download the fonts and include them in the project. That will allow us to use the font-display and it would load the fonts faster (because we use http2 so we will skip quite a few round trips). What do you think? |
@alexdor Yea, I was thinking the same to download and serve them through our project itself. |
I would create a folder inside src/styles but you can create it where ever you want : ) It's better to do it inside the src/ folder in order to not skip webpack preparation of the assets. Note: Don't forget to read this part https://github.com/ossn/fixme#adding-images-fonts-and-files in order to avoid common issues : ) |
@alexdor created a PR! :) |
@alexdor Also I wanted to ask why do we use Raleway as the main font when numbers in Raleway font look up & down? Any specific reason for it? |
@himankpathak The designers used it so we had to : ) |
Okay @alexdor :P |
Thanks @himankpathak : ) You could always try to tackle #15 or this comment #28 (comment) |
Leverage the font-display CSS feature to ensure text is user-visible while webfonts are loading. Learn more
The text was updated successfully, but these errors were encountered: